Jackie-Jiang commented on code in PR #11371:
URL: https://github.com/apache/pinot/pull/11371#discussion_r1297473945
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -314,8 +316,16 @@ void refreshSegmentStates() {
}
if (!enabledCandidates.isEmpty()) {
instanceCandidatesMap.put(segment, enabledCandidates);
+ } else {
+ // Do not count new segment as unavailable
+ List<String> candidateInstances = new ArrayList<>(candidates.size());
+ for (SegmentInstanceCandidate candidate : candidates) {
+ candidateInstances.add(candidate.getInstance());
+ }
+ LOGGER.info("Failed to find servers hosting new segment: {} for table:
{} "
+ + "(all candidate instances: {} are disabled, not counting
segment as unavailable)", segment,
Review Comment:
Same as above, but revised the log to be easier to differentiate with old
segment one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
