Jackie-Jiang commented on code in PR #11371:
URL: https://github.com/apache/pinot/pull/11371#discussion_r1297472853
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -314,8 +316,16 @@ void refreshSegmentStates() {
}
if (!enabledCandidates.isEmpty()) {
instanceCandidatesMap.put(segment, enabledCandidates);
+ } else {
+ // Do not count new segment as unavailable
Review Comment:
We don't track available segment but only unavailable ones, so IMO it is
more clear to comment on whether it is counted as unavailable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
