Jackie-Jiang commented on code in PR #11307:
URL: https://github.com/apache/pinot/pull/11307#discussion_r1294198129
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -942,6 +950,30 @@ private static Set<String>
getSegmentPartitionedColumns(@Nullable TableConfig ta
return segmentPartitionedColumns;
}
+ /**
+ * Retrieve multivalued columns for a table.
+ * From the table Schema , we get the multi valued columns of dimension
fields.
+ *
+ * @param tableCache
+ * @param tableName
+ * @return multivalued columns of the table .
+ */
+ private static Set<String> getMultiValuedColumns(TableCache tableCache,
String tableName) {
Review Comment:
We still want to read schema once, but no need to collect the MV columns up
front. You can use `schema.getFieldSpecFor(col)` to lookup the `FieldSpec` for
a column. The assumption here is that we don't usually have that many
aggregation functions comparing to number of columns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
