[GitHub] [pinot] deemoliu commented on a diff in pull request #10927: [WIP] improve disk read for partial upsert handler

[via GitHub]

deemoliu commented on code in PR #10927:
URL: https://github.com/apache/pinot/pull/10927#discussion_r1289223298


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -254,7 +256,9 @@ protected void doAddRecord(MutableSegment segment, 
RecordInfo recordInfo) {
   @Override
   protected GenericRow doUpdateRecord(GenericRow record, RecordInfo 
recordInfo) {
     assert _partialUpsertHandler != null;
-    AtomicReference<GenericRow> previousRecordReference = new 
AtomicReference<>();
+    AtomicReference<GenericRow> mergedRowReference = new AtomicReference<>();

Review Comment:
   gotcha. i have pushed the logic from the upsertMetadata manager to handler, 
and do in-place merging in the handler.



##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -268,13 +272,28 @@ protected GenericRow doUpdateRecord(GenericRow record, 
RecordInfo recordInfo) {
             int currentDocId = recordLocation.getDocId();
             if (currentQueryableDocIds == null || 
currentQueryableDocIds.contains(currentDocId)) {
               _reuse.clear();
-              
previousRecordReference.set(currentSegment.getRecord(currentDocId, _reuse));
+              for (String column: record.getFieldToValueMap().keySet()) {
+                PinotSegmentColumnReader pinotSegmentColumnReader =
+                    new PinotSegmentColumnReader(recordLocation.getSegment(), 
column);

Review Comment:
   gotcha, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org