deemoliu commented on code in PR #10927:
URL: https://github.com/apache/pinot/pull/10927#discussion_r1289221159
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java:
##########
@@ -90,4 +90,31 @@ public GenericRow merge(GenericRow previousRecord,
GenericRow newRecord) {
}
return newRecord;
}
+
+ protected PartialUpsertMerger getMergerForColumn(String column) {
+ return _column2Mergers.getOrDefault(column, _defaultPartialUpsertMerger);
+ }
+
+ public GenericRow merge(String column, Object previousValue, GenericRow
newRecord) {
+ if (!_primaryKeyColumns.contains(column)) {
Review Comment:
thanks @Jackie-Jiang i have rewrite this interface, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
