gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1277779616
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/TransformOperator.java:
##########
@@ -86,13 +86,14 @@ protected TransferableBlock getNextBlock() {
try {
TransferableBlock block = _upstreamOperator.nextBlock();
return transform(block);
- } catch (Exception e) {
+ } catch (RuntimeException e) {
return TransferableBlockUtils.getErrorTransferableBlock(e);
}
}
- private TransferableBlock transform(TransferableBlock block)
- throws Exception {
+ private TransferableBlock transform(TransferableBlock block) {
+ // TODO: Other operators keep the first erroneous block, while this keep
the last.
+ // We should decide what is what we want to do and be consistent with
that.
Review Comment:
Discussion opened to do not forget about this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
