gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1277744002
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -159,12 +155,16 @@ public String toExplainString() {
@Override
protected TransferableBlock getNextBlock() {
try {
- if (!_readyToConstruct && !consumeInputBlocks()) {
- return TransferableBlockUtils.getNoOpTransferableBlock();
+ TransferableBlock finalBlock;
+ if (_isGroupByAggregation) {
+ finalBlock = consumeGroupBy();
Review Comment:
This is a lateral change, not completely necessary, but helps readibility,
removes a condition inside the loom and makes it easier the JIT compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
