KKcorps commented on PR #11110: URL: https://github.com/apache/pinot/pull/11110#issuecomment-1649553354
> > > Changes look good. Trying to understand the motivation behind this metric. > > > > > > Basically we now create valid doc id snapshot on each segment commit. If these snapshots are not present, it affects the restart times for upsert tables by a lot. The metric can help us determine if we are good to rollout the servers or not. > > Would be great if you can include this in the metric description! already added as comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org