navina commented on code in PR #11110:
URL: https://github.com/apache/pinot/pull/11110#discussion_r1264226124
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -48,7 +48,8 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
JVM_HEAP_USED_BYTES("bytes", true),
// Ingestion delay metrics
REALTIME_INGESTION_DELAY_MS("milliseconds", false),
- END_TO_END_REALTIME_INGESTION_DELAY_MS("milliseconds", false);
+ END_TO_END_REALTIME_INGESTION_DELAY_MS("milliseconds", false),
+ UPSERT_VALID_DOC_ID_SNAPSHOT_COUNT("upsertValidDocIdSnapshotCount", false);
Review Comment:
can you add a description along with this metric enum?
See example
[here](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java#L29)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
