walterddr commented on code in PR #11117:
URL: https://github.com/apache/pinot/pull/11117#discussion_r1271461855


##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -90,6 +90,11 @@ public enum TransformFunctionType {
   // date type conversion functions
   CAST("cast"),
 
+  // object type
+  ARRAY_TO_MV("arrayToMV",
+      ReturnTypes.cascade(opBinding -> 
positionalComponentReturnType(opBinding, 0), SqlTypeTransforms.FORCE_NULLABLE),

Review Comment:
   actually ignored previous comment, did a bit of research and it seems like 
registering TransformFunctionType without an actual impl is better than having 
to parse scalar function annotation, which doesn't really allow anything other 
than primitives



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to