walterddr commented on code in PR #11117:
URL: https://github.com/apache/pinot/pull/11117#discussion_r1271453437
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -90,6 +90,11 @@ public enum TransformFunctionType {
// date type conversion functions
CAST("cast"),
+ // object type
+ ARRAY_TO_MV("arrayToMV",
+ ReturnTypes.cascade(opBinding ->
positionalComponentReturnType(opBinding, 0), SqlTypeTransforms.FORCE_NULLABLE),
Review Comment:
let's first create a component return type registry on @ScalarFunction so we
dont have to modify the transform function side.
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -90,6 +90,11 @@ public enum TransformFunctionType {
// date type conversion functions
CAST("cast"),
+ // object type
+ ARRAY_TO_MV("arrayToMV",
Review Comment:
yeah we need to figure out a proper way b/c out put of a select is an array,
but the table config / schema will still call this as MV column as convension.
both have some confusion, but as long as the document is proper we should be
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
