klsince commented on code in PR #11020:
URL: https://github.com/apache/pinot/pull/11020#discussion_r1256160640
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java:
##########
@@ -35,8 +32,7 @@ private TableUpsertMetadataManagerFactory() {
private static final Logger LOGGER =
LoggerFactory.getLogger(TableUpsertMetadataManagerFactory.class);
- public static TableUpsertMetadataManager create(TableConfig tableConfig,
Schema schema,
- TableDataManager tableDataManager, ServerMetrics serverMetrics) {
+ public static TableUpsertMetadataManager create(TableConfig tableConfig) {
Review Comment:
kk. I made this change because isUpsertEnabled() is called in addSegment()
to handle upsert specific states. So need to set `_tableUpsertMetadataManager`
before preloading segments which happens as part of init() method. lemme use a
boolean var for here.
```
public boolean isUpsertEnabled() {
return _tableUpsertMetadataManager != null;
}
public void addSegment(ImmutableSegment immutableSegment) {
if (isUpsertEnabled()) {
handleUpsert(immutableSegment);
return;
}
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
