INNOCENT-BOY commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1254156577
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java:
##########
@@ -95,8 +101,14 @@ public static void validate(Schema schema,
List<TableConfig> tableConfigs) {
* 6) Schema validations from {@link Schema#validate}
*/
public static void validate(Schema schema) {
+ validate(schema, false);
+ }
+
+ public static void validate(Schema schema, boolean isIgnoreCase) {
schema.validate();
+ List allColumnName = schema.getColumnNames().stream().map(column ->
column.toLowerCase())
+ .collect(Collectors.toList());
Review Comment:
LGTM, I will update my pr to make it more efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
