walterddr commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1246860273
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -359,7 +359,8 @@ private void validateSchemaInternal(Schema schema) {
validateSchemaName(schema.getSchemaName());
try {
List<TableConfig> tableConfigs =
_pinotHelixResourceManager.getTableConfigsForSchema(schema.getSchemaName());
- SchemaUtils.validate(schema, tableConfigs);
+ boolean isIgnoreCase = _pinotHelixResourceManager.isIgnoreCase();
+ SchemaUtils.validate(schema, tableConfigs, isIgnoreCase);
Review Comment:
no that's not what I meant.
for example in `PinotQueryResource` it inject ControllerConf which has the
case sensitivity config key in it presumably. instead of inject helix manager
you can directly inject the config which is what we wanted here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
