Jackie-Jiang commented on code in PR #10982:
URL: https://github.com/apache/pinot/pull/10982#discussion_r1247531397
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -42,6 +42,7 @@
import org.apache.pinot.common.request.context.RequestContextUtils;
import org.apache.pinot.common.tier.TierFactory;
import org.apache.pinot.common.utils.config.TagNameUtils;
+import org.apache.pinot.segment.local.aggregator.ValueAggregatorFactory;
Review Comment:
This is not the correct `ValueAggregatorFactory`. We should import
`org.apache.pinot.core.segment.processing.aggregator.ValueAggregatorFactory`
which is used for `RealtimeToOfflineTask`
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -523,8 +524,17 @@ static void validateTaskConfigs(TableConfig tableConfig,
Schema schema) {
if (entry.getKey().endsWith(".aggregationType")) {
Preconditions.checkState(columnNames.contains(StringUtils.removeEnd(entry.getKey(),
".aggregationType")),
String.format("Column \"%s\" not found in schema!",
entry.getKey()));
- Preconditions.checkState(ImmutableSet.of("SUM", "MAX",
"MIN").contains(entry.getValue().toUpperCase()),
- String.format("Column \"%s\" has invalid aggregate type:
%s", entry.getKey(), entry.getValue()));
+ try {
+ // check that it's a valid aggregation function type
+ AggregationFunctionType aft =
AggregationFunctionType.valueOf(entry.getValue().toUpperCase());
Review Comment:
```suggestion
AggregationFunctionType aft =
AggregationFunctionType.getAggregationFunctionType(entry.getValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
