andimiller commented on code in PR #10982:
URL: https://github.com/apache/pinot/pull/10982#discussion_r1244438998
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java:
##########
@@ -1755,6 +1755,14 @@ public void testTaskConfig() {
} catch (IllegalStateException e) {
Assert.assertTrue(e.getMessage().contains("has invalid aggregate type"));
}
+
+ // valid agg
+ HashMap<String, String> validAggConfig = new
HashMap<>(realtimeToOfflineTaskConfig);
Review Comment:
anything available in the `ValueAggregatorFactory` methods should be valid
here, which is why I've implemented it this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
