walterddr commented on code in PR #10943:
URL: https://github.com/apache/pinot/pull/10943#discussion_r1239097091
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseStats.java:
##########
@@ -33,7 +33,7 @@
// same metadataKey
// TODO: Replace member fields with a simple map of <MetadataKey, Object>
// TODO: Add a subStat field, stage level subStats will contain each operator
stats
-@JsonPropertyOrder({"exceptions", "numBlocks", "numRows",
"stageExecutionTimeMs", "stageExecutionUnit",
+@JsonPropertyOrder({"requestId", "exceptions", "numBlocks", "numRows",
"stageExecutionTimeMs", "stageExecutionUnit",
Review Comment:
requestID generated in v1 engine doesn't include a hashed encoding of the
broker address. so essentially this could cause confusion (e.g. requestID
starts with 0 and you might get another 0 when hitting a different broker)
see: #10789 for more info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
