mingmxu opened a new pull request, #10943: URL: https://github.com/apache/pinot/pull/10943
# issue https://github.com/apache/pinot/issues/10884 # what's the problem? * `requestId` is available only for response with v2 engine; * `requestId` is not exposed in java-client; # What's the change? * `getRequestId()` and `setRequestId()` is moved from `BrokerResponseNativeV2` to `org.apache.pinot.common.response.BrokerResponse`; * return `requestId` in `BaseBrokerRequestHandler#handleRequest()` which can benefit both `SingleConnectionBrokerRequestHandler` and `GrpcBrokerRequestHandler`; * parse `requestId` in `org.apache.pinot.client.BrokerResponse`, the field is set to optional for client/server compatibility; # Note * `BaseBrokerRequestHandler`(v1 engine) could generate duplicate requestId crossing brokers, leave it in another PR if prefer to fix; * there're still two implementations of `BrokerResponse`, also leave it to another PR to limit change scope; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
