Jackie-Jiang commented on PR #10836: URL: https://github.com/apache/pinot/pull/10836#issuecomment-1579313827
> > One way is to create a different wrapper class to hold the modified configs > > Why do you need a wrapper class? wouldn't a builder pattern like [this](https://github.com/apache/pinot/compare/master...navina:pinot:upsertconfig-immutable?expand=1#diff-ca3b0955d952613f601141006296abc18aa0a521927a700bd8fe71db45616baaR160) be sufficient? > > I don't see a real need to modify the upsert configs anywhere. `comparisonColumn` might not be set in the upsert config, and we want to use time column as the comparison column if it is not configured. If we pass the `UpsertConfig` to the partition level metadata manager, we need to apply the same logic again for each partition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
