deemoliu commented on PR #10836: URL: https://github.com/apache/pinot/pull/10836#issuecomment-1574399041
> I don't think we want to make this change. The constructor for the `TableUpsertMetadataManager` takes the `UpsertConfig` from `TableConfig`, and process the value if needed (e.g. use time column as comparison column if not configured). We don't want to repeat the same steps in `PartitionUpsertMetadataManager`, so we directly pass the value @Jackie-Jiang Can I assign the `comparisonColumns` value to upsertConfig and pass it to PartitionUpsertMetadataManager? then we don't need to repeat the same steps in partitionlevel upsert metadata managers. The purpose of the change is to address a comment from @KKcorps. https://github.com/apache/pinot/pull/10047#discussion_r1189404582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
