Jackie-Jiang commented on code in PR #10771:
URL: https://github.com/apache/pinot/pull/10771#discussion_r1214874857
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -315,10 +315,8 @@ public void onInstanceConfigChange(List<InstanceConfig>
instanceConfigs, Notific
HelixConfigScope helixConfigScope =
new
HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(_helixClusterName).build();
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
- Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY,
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
- boolean caseInsensitive =
- Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY))
|| Boolean.parseBoolean(
- configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
+ Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY));
+ boolean caseInsensitive =
Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY));
Review Comment:
If the key is not configured, `caseInsensitive` should be true. Currently it
will be false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
