soumitra-st commented on PR #10771:
URL: https://github.com/apache/pinot/pull/10771#issuecomment-1557189891
> Let's also make sure the existing cluster with case insensitive = false
won't be automatically turned on after this change.
@xiangfu0 , one question here:
Current code is:
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false)
||
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY,
false);
Which means, by default Pinot is case sensitive, and if any of the two
properties (Helix.ENABLE_CASE_INSENSITIVE_KEY,
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) are set to true, Pinot becomes
case insensitive.
There are two possible changes:
1. Change the default to true, and ||
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, true)
||
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY,
true);
Now, Pinot is case insensitive by default, but BOTH of these properties
(Helix.ENABLE_CASE_INSENSITIVE_KEY,
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) would have to be set to false, to
make Pinot case sensitive.
2. Change the default to true, and &&
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, true)
&&
_brokerConf.getProperty(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY,
true);
In this case, Pinot is case insensitive by default, but ANY of these
properties (Helix.ENABLE_CASE_INSENSITIVE_KEY,
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY) can be set to false, to make
Pinot case sensitive.
My preference is 2, since Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY is a
deprecated property, hence asking users to set both does not make sense as in
option 1.
Please advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
