snleee commented on code in PR #10731: URL: https://github.com/apache/pinot/pull/10731#discussion_r1187974822
########## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskExecutor.java: ########## @@ -287,6 +287,9 @@ protected SegmentGenerationTaskSpec generateTaskSpec(Map<String, String> taskCon recordReaderSpec.setDataFormat(taskConfigs.get(BatchConfigProperties.INPUT_FORMAT)); recordReaderSpec.setClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CLASS)); recordReaderSpec.setConfigClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CONFIG_CLASS)); + recordReaderSpec.setConfigs( Review Comment: Have we set up the code style? If not, let's set up the pinot style in IDE and apply the code style change. https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#setup-ide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org