Jackie-Jiang commented on PR #10656: URL: https://github.com/apache/pinot/pull/10656#issuecomment-1526119626
> Question for `InstanceAssignmentConfigUtils`, since we are creating an object of `InstanceReplicaGroupPartitionConfig`[L116, L121] and with this change we have added `partitionColumn` as a class member, we need to provide the value of it. I thought it's better to give the value we are extracting there instead of setting it as `null`. WDYT? Good point. We should set the `partitionColumn` in the generated `InstanceReplicaGroupPartitionConfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
