abhioncbr commented on PR #10656: URL: https://github.com/apache/pinot/pull/10656#issuecomment-1517047083
> This is backwards incompatible. Why do we want to do this without first ensuring / aligning that everyone has their production deployment migrated to new style replica group config ? Thanks for mentioning it; I didn't consider backward compatibility while making the changes. So, to make this backward compatible, we can't delete the `ReplicaGroupStrategyConfig` class. As the first step, can we add the `partitionColumn` field to the `InstanceReplicaGroupPartitionConfig` class? However, what if a user provides a different `partitionColumn` value in both configs? Which one would be applicable, `ReplicaGroupStrategyConfig` or `InstanceReplicaGroupPartitionConfig`? Also, please give pointers on some of the factors I should consider for making the change backward compatible. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
