chenboat commented on code in PR #10643: URL: https://github.com/apache/pinot/pull/10643#discussion_r1179485824
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java: ########## @@ -77,6 +88,14 @@ public static AggregationFunction getAggregationFunction(FunctionContext functio // PercentileRawTDigest String percentileString = remainingFunctionName.substring(10); return new PercentileRawTDigestAggregationFunction(firstArgument, parsePercentileToInt(percentileString)); + } else if (remainingFunctionName.matches("KLL\\d+")) { + // PercentileKLL + String percentileString = remainingFunctionName.substring(3); Review Comment: why 3? can you add a comment to explain? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org