chiquelo commented on code in PR #10643:
URL: https://github.com/apache/pinot/pull/10643#discussion_r1178263145
##########
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java:
##########
@@ -918,6 +923,26 @@ public Sketch deserialize(ByteBuffer byteBuffer) {
}
};
+ public static final ObjectSerDe<KllSketch> KLL_SKETCH_SER_DE = new
ObjectSerDe<KllSketch>() {
Review Comment:
Should this variable name reflect the choice of KllDoubleSketch over
KllFloatSketch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
