61yao commented on code in PR #10594:
URL: https://github.com/apache/pinot/pull/10594#discussion_r1178565673
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CoalesceTransformFunction.java:
##########
@@ -116,24 +108,24 @@ private int[] getIntTransformResults(ValueBlock
valueBlock) {
int width = _transformFunctions.length;
RoaringBitmap[] nullBitMaps = getNullBitMaps(valueBlock,
_transformFunctions);
int[][] data = new int[width][length];
- RoaringBitmap filledData = new RoaringBitmap();
+ BitSet filledData = new BitSet(); // indicates whether certain column has
be filled in data.
for (int i = 0; i < length; i++) {
boolean hasNonNullValue = false;
for (int j = 0; j < width; j++) {
// Consider value as null only when null option is enabled.
if (nullBitMaps[j] != null && nullBitMaps[j].contains(i)) {
continue;
}
- if (!filledData.contains(j)) {
- filledData.add(j);
+ if (!filledData.get(j)) {
+ filledData.set(j);
data[j] = _transformFunctions[j].transformToIntValuesSV(valueBlock);
}
Review Comment:
Is the first suggestion to remove filledData? filledData is set to terminate
early so we don't need to do evaluation that we don't need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
