gortiz commented on code in PR #10687:
URL: https://github.com/apache/pinot/pull/10687#discussion_r1176673606
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/geospatial/MutableH3Index.java:
##########
@@ -49,6 +53,17 @@ public MutableH3Index(H3IndexResolution resolution)
_lowestResolution = resolution.getLowestResolution();
}
+ @Override
+ public void add(@Nonnull Object value, int dictId, int docId) {
+ Geometry geometry = GeometrySerializer.deserialize((byte[]) value);
+ add(geometry);
+ }
+
+ @Override
+ public void add(@Nonnull Object[] values, @Nullable int[] dictIds, int
docId) {
+ throw new UnsupportedOperationException("Mutable H3 indexes are not
supported for multi-valued columns");
Review Comment:
In fact previous code what it does is to just ignore the value. Now the
H3IndexType itself is the one that returns null (aka no mutable supplot) when
the column is multi-valuated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
