gortiz commented on code in PR #10687:
URL: https://github.com/apache/pinot/pull/10687#discussion_r1176664501
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -768,115 +679,28 @@ private void addNewRow(int docId, GenericRow row) {
}
}
}
-
- // Update text index
- MutableTextIndex textIndex = indexContainer._textIndex;
- if (textIndex != null) {
- try {
- textIndex.add((String) value);
- } catch (Exception e) {
- recordIndexingError(FieldConfig.IndexType.TEXT, e);
- }
- }
-
- // Update json index
- MutableJsonIndex jsonIndex = indexContainer._jsonIndex;
- if (jsonIndex != null) {
- try {
- jsonIndex.add((String) value);
- } catch (Exception e) {
- recordIndexingError(FieldConfig.IndexType.JSON, e);
- }
- }
-
- // Update H3 index
- MutableH3Index h3Index = indexContainer._h3Index;
- if (h3Index != null) {
- try {
- h3Index.add(GeometrySerializer.deserialize((byte[]) value));
- } catch (Exception e) {
- recordIndexingError(FieldConfig.IndexType.H3, e);
- }
- }
Review Comment:
As you can see, FST is not modified here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
