lakshmanan-v commented on code in PR #10638:
URL: https://github.com/apache/pinot/pull/10638#discussion_r1171749117
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionTimeouts.java:
##########
@@ -25,18 +25,26 @@ public class ConnectionTimeouts {
private final int _readTimeoutMs;
private final int _connectTimeoutMs;
private final int _handshakeTimeoutMs;
+ private final Integer _requestTimeoutMs;
Review Comment:
The intent was to not to set any default value here unless the user has
spcified it and continue using current behavior (AsyncHttpClient's default
timeout). Was deciding between Integer object with null vs Optional, instead of
small int with 0/-1 to indicate the user not setting the request timeout
property. Didn't see Optional being used in the code, so used null checks for
both threadpool name and request timeout.
I think we can set 60 secs default, which may be okay. Was just playing it
safe. If you guys are fine with it, i can set 60s default (which is what we
use for read time out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
