lakshmanan-v commented on code in PR #10638: URL: https://github.com/apache/pinot/pull/10638#discussion_r1171615585
########## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionTimeouts.java: ########## @@ -25,18 +25,26 @@ public class ConnectionTimeouts { private final int _readTimeoutMs; private final int _connectTimeoutMs; private final int _handshakeTimeoutMs; + private final Integer _requestTimeoutMs; Review Comment: Would like to keep this optional, not change the default behavior of the existing clients which are using asyncHttpClient's default request timeout (which is 60 seconds i believe) when they upgrade to new version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org