gortiz commented on PR #10584:
URL: https://github.com/apache/pinot/pull/10584#issuecomment-1502099192

   > What happens if we deploy this, then it switches? I guess enabled: false 
is the only case where the behavior will switch?
   
   That is my concern. The easiest change would be to just ignore the `enabled` 
attribute, so:
   
   | when enabled was  | prev this PR  | after this PR  | if we use disabled   |
   |---|---|---|---|
   | not defined  |  sometimes disabled the index | enable the index  | enable 
the index |
   | null  | sometimes disable the index  | enable the index  | enable the 
index  |
   | true  | enable the index  | enable the index  | enable the index  |
   | false  | disable the index  | disable the index  | **enable the index**  |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to