Jackie-Jiang commented on PR #10584:
URL: https://github.com/apache/pinot/pull/10584#issuecomment-1502031312
> I still think from a user perspective is cleaner to say
>
> ```js
> {
> bloom: {
> enabled: false
> }
> }
> ```
>
> Than
>
> ```js
> {
> bloom: {
> disabled: true
> }
> }
> ```
>
> But I'm open to change that if other people think like @Jackie-Jiang. What
I think that is important is to decide that ASAP. Once people start using
`enabled` it would be more difficult to change it.
Agree. Once the key is determined, it will be hard to change.
One less common example that IMO can lead to surprising behavior is:
```
{
enabled: null
}
```
The above example will actually enable the index
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
