xiangfu0 commented on code in PR #10543:
URL: https://github.com/apache/pinot/pull/10543#discussion_r1158906268
##########
pinot-tools/src/main/java/org/apache/pinot/tools/MultistageEngineQuickStart.java:
##########
@@ -94,7 +94,6 @@ public String[] getDefaultBatchTableDirectories() {
@Override
public Map<String, Object> getConfigOverrides() {
Map<String, Object> overrides = new HashMap<>(super.getConfigOverrides());
- overrides.put("pinot.multistage.engine.enabled", "true");
overrides.put("pinot.server.instance.currentDataTableVersion", 4);
Review Comment:
Good point, any idea this doesn't fail on integration test?
##########
pinot-tools/src/main/java/org/apache/pinot/tools/MultistageEngineQuickStart.java:
##########
@@ -94,7 +94,6 @@ public String[] getDefaultBatchTableDirectories() {
@Override
public Map<String, Object> getConfigOverrides() {
Map<String, Object> overrides = new HashMap<>(super.getConfigOverrides());
- overrides.put("pinot.multistage.engine.enabled", "true");
overrides.put("pinot.server.instance.currentDataTableVersion", 4);
Review Comment:
cc: @walterddr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
