siddharthteotia commented on code in PR #10543:
URL: https://github.com/apache/pinot/pull/10543#discussion_r1158539072
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -170,6 +171,12 @@ public void init(PinotConfiguration serverConf)
// NOTE: Need to add the instance id to the config because it is
required in HelixInstanceDataManagerConfig
_serverConf.addProperty(Server.CONFIG_OF_INSTANCE_ID, _instanceId);
}
+ if (_serverConf.getProperty(QueryConfig.KEY_OF_QUERY_SERVER_PORT,
QueryConfig.DEFAULT_QUERY_SERVER_PORT) == 0) {
+ _serverConf.setProperty(QueryConfig.KEY_OF_QUERY_SERVER_PORT,
NetUtils.findOpenPort());
+ }
+ if (_serverConf.getProperty(QueryConfig.KEY_OF_QUERY_RUNNER_PORT,
QueryConfig.DEFAULT_QUERY_RUNNER_PORT) == 0) {
+ _serverConf.setProperty(QueryConfig.KEY_OF_QUERY_RUNNER_PORT,
NetUtils.findOpenPort());
Review Comment:
Doing this can have query runner port differ from one worker to another ? In
that case, how will they talk to each other ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
