61yao commented on code in PR #10192: URL: https://github.com/apache/pinot/pull/10192#discussion_r1137989320
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexPlugin.java: ########## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.segment.spi.index; + +/** + * IndexPlugins are the way {@link IndexType}s are registered in a {@link IndexService}. + * + * In order to create an IndexService, a set of IndexPlugin must be provided. Although IndexTypes could be directly + * added into a IndexService, this indirection is used to decouple the way indexes are discovered + * (usually by {@link java.util.ServiceLoader} services) and the actual implementation. + * + * In order to mark a class as a {@link java.util.ServiceLoader} service, some metadata has to be added. Java modules + * define a typesafe way to define services, but given that Pinot does not use them right now, the easier way to create Review Comment: I am not very familiar with the ServiceLoader. but say in the future, we want to use the type. Will that be a problem? What's the implication of using Google AutoService? Compared with the other type safe method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
