navina commented on code in PR #10192:
URL: https://github.com/apache/pinot/pull/10192#discussion_r1137789064
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/bloom/OnHeapGuavaBloomFilterCreator.java:
##########
@@ -47,9 +48,18 @@ public class OnHeapGuavaBloomFilterCreator implements
BloomFilterCreator {
private final File _bloomFilterFile;
private final BloomFilter<String> _bloomFilter;
+ private final FieldSpec.DataType _dataType;
+ // TODO: This method is here for compatibility reasons, should be removed in
future PRs
Review Comment:
nit: In my experience, it is better to define an "exit criteria" for the
deprecated feature. Meaning "when" in the future can this be safely removed.
In my previous team, we used something like:
```
exit_criteria = "when PR #XYZ is merged in oss"
```
In this case, you can mention when it will no longer matter. It can also be
as straightforward as "remove in releaseX.Y.Z"
I don't know if Pinot has a standard practice for removing deprecated
feature/code. But just my 2 cents.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/bloom/BloomIndexType.java:
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.pinot.segment.local.segment.index.bloom;
+
+import java.util.Map;
+import javax.annotation.Nullable;
+import
org.apache.pinot.segment.local.segment.creator.impl.bloom.OnHeapGuavaBloomFilterCreator;
+import
org.apache.pinot.segment.local.segment.index.readers.bloom.BloomFilterReaderFactory;
+import org.apache.pinot.segment.spi.ColumnMetadata;
+import org.apache.pinot.segment.spi.Constants;
+import org.apache.pinot.segment.spi.V1Constants;
+import org.apache.pinot.segment.spi.creator.IndexCreationContext;
+import org.apache.pinot.segment.spi.index.FieldIndexConfigs;
+import org.apache.pinot.segment.spi.index.IndexHandler;
+import org.apache.pinot.segment.spi.index.IndexReaderFactory;
+import org.apache.pinot.segment.spi.index.IndexType;
+import org.apache.pinot.segment.spi.index.creator.BloomFilterCreator;
+import org.apache.pinot.segment.spi.index.reader.BloomFilterReader;
+import org.apache.pinot.segment.spi.memory.PinotDataBuffer;
+import org.apache.pinot.segment.spi.store.SegmentDirectory;
+import org.apache.pinot.spi.config.table.BloomFilterConfig;
+import org.apache.pinot.spi.config.table.TableConfig;
+import org.apache.pinot.spi.data.Schema;
+
+public class BloomIndexType implements IndexType<BloomFilterConfig,
BloomFilterReader, BloomFilterCreator> {
+ public static final BloomIndexType INSTANCE = new BloomIndexType();
+
+ @Override
+ public String getId() {
+ return "bloom_filter";
+ }
+
+ @Override
+ public Class<BloomFilterConfig> getIndexConfigClass() {
+ return BloomFilterConfig.class;
+ }
+
+ @Override
+ public BloomFilterConfig getDefaultConfig() {
+ return BloomFilterConfig.DISABLED;
+ }
+
+ @Override
+ public BloomFilterConfig getConfig(TableConfig tableConfig, Schema schema) {
+ throw new UnsupportedOperationException("To be implemented in a future
PR");
+ }
+
+ @Override
+ public BloomFilterCreator createIndexCreator(IndexCreationContext context,
BloomFilterConfig indexConfig) {
+ int cardinality = context.getCardinality();
+ if (cardinality == Constants.UNKNOWN_CARDINALITY) {
+ // This is when we're creating bloom filters for non dictionary encoded
cols where exact cardinality is not
+ // known beforehand.
+ // Since this field is only used for the estimate cardinality, using
total # of entries instead
+ // TODO (saurabh) Check if we can do a better estimate
+ cardinality = context.getTotalNumberOfEntries();
+ }
+ return new OnHeapGuavaBloomFilterCreator(context.getIndexDir(),
context.getFieldSpec().getName(), cardinality,
+ indexConfig, context.getFieldSpec().getDataType());
+ }
+
+ @Override
+ public IndexReaderFactory<BloomFilterReader> getReaderFactory() {
+ return new IndexReaderFactory.Default<BloomFilterConfig,
BloomFilterReader>() {
Review Comment:
+1 to @saurabhd336 's comment.
Creating a new instance for what is meant to be a stateless instance is a
little unnecessary. I agree that GC will take care of it. But it may not be
obvious to every developer. So, better to move it to a single instance and
share it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
