ankitsultana commented on code in PR #10322:
URL: https://github.com/apache/pinot/pull/10322#discussion_r1128195721
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -49,12 +48,20 @@
*/
public class MailboxContentStreamObserver implements
StreamObserver<Mailbox.MailboxContent> {
private static final Logger LOGGER =
LoggerFactory.getLogger(MailboxContentStreamObserver.class);
+ private static final int DEFAULT_MAX_PENDING_MAILBOX_CONTENT = 5;
+ private static final long DEFAULT_QUEUE_POLL_TIMEOUT_MS = 120_000;
Review Comment:
This is the timeout for the queue offer and not poll (it should be renamed).
The receive operator will return null if there's no data in the receivingBuffer.
This should ideally be tied to the query deadline but we don't have it in
MailboxContentStreamObserver right now. At present I kept it to a reasonably
large number. We can consider either increasing or decreasing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
