ankitsultana commented on code in PR #10322:
URL: https://github.com/apache/pinot/pull/10322#discussion_r1125056403
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -93,5 +100,25 @@ protected void sendBlock(SendingMailbox<TransferableBlock>
sendingMailbox, Trans
}
}
- protected abstract void route(List<SendingMailbox<TransferableBlock>>
destinations, TransferableBlock block);
+ protected abstract void route(List<SendingMailbox<TransferableBlock>>
destinations, TransferableBlock block)
+ throws Exception;
+
+ // Called when the OpChain gracefully returns.
+ // TODO: This is a no-op right now.
+ public void close() {
+ for (SendingMailbox sendingMailbox : _sendingMailboxes) {
+ if (sendingMailbox.isInitialized() && !sendingMailbox.isClosed()) {
+ LOGGER.info("SendingMailbox={} was not closed presumably because
receiver hasn't completed processing",
Review Comment:
self-review: log level should be debug
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PlanRequestContext.java:
##########
@@ -34,17 +34,19 @@ public class PlanRequestContext {
protected final long _requestId;
protected final int _stageId;
private final long _timeoutMs;
+ private final long _deadlineMs;
protected final VirtualServerAddress _server;
protected final Map<Integer, StageMetadata> _metadataMap;
protected final List<MailboxIdentifier> _receivingMailboxes = new
ArrayList<>();
public PlanRequestContext(MailboxService<TransferableBlock> mailboxService,
long requestId, int stageId,
- long timeoutMs, VirtualServerAddress server, Map<Integer, StageMetadata>
metadataMap) {
+ long timeoutMs, long deadlineMs, VirtualServerAddress server,
Map<Integer, StageMetadata> metadataMap) {
_mailboxService = mailboxService;
_requestId = requestId;
_stageId = stageId;
_timeoutMs = timeoutMs;
Review Comment:
self-review: We don't need to store timeoutMs anymore. We can pass deadline
directly to `MailboxReceiveOperator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
