Jackie-Jiang commented on code in PR #10371: URL: https://github.com/apache/pinot/pull/10371#discussion_r1127086390
########## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java: ########## @@ -28,9 +28,207 @@ public class FilterOperatorUtils { + + private static volatile Implementation _instance = new Implementation(); Review Comment: This is good learning for me. I thought reading volatile is always from main memory, but seems it can be read from L1 cache as long as the value is not written to for most modern hardware -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org