gortiz commented on PR #10371: URL: https://github.com/apache/pinot/pull/10371#issuecomment-1455642343
> To minimize the change, we can still keep the FilterOperatorUtils and all the static util function, but also make an interface (basically add an interface for the methods, and make this class the default implementation for the interface). I'd imagine you want to plug in some other implementation via the setImplementation(), instead of extending this class, you may implement the interface Isn't that almost the same as I did? The only difference is whether the _thing_ is a class or an interface. I can change it (and I guess I will), but TBH it doesn't seem something that important. The only difference is whether implementation can extend other classes, which I don't think that will be that common (and in that case it could be changed when needed!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
