saurabhd336 commented on code in PR #10255: URL: https://github.com/apache/pinot/pull/10255#discussion_r1126077154
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceAssignmentRestletResource.java: ########## @@ -315,16 +407,16 @@ private void removeInstancePartitionsHelper(String instancePartitionsName) { @Path("/tables/{tableName}/replaceInstance") @Authenticate(AccessType.CREATE) @ApiOperation(value = "Replace an instance in the instance partitions") - public Map<InstancePartitionsType, InstancePartitions> replaceInstance( + public Map<String, InstancePartitions> replaceInstance( @ApiParam(value = "Name of the table") @PathParam("tableName") String tableName, - @ApiParam(value = "OFFLINE|CONSUMING|COMPLETED") @QueryParam("type") @Nullable - InstancePartitionsType instancePartitionsType, + @ApiParam(value = "OFFLINE|CONSUMING|COMPLETED|Name of the tier") @QueryParam("type") @Nullable Review Comment: Ack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org