jasperjiaguo commented on code in PR #10373:
URL: https://github.com/apache/pinot/pull/10373#discussion_r1124938208
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -756,10 +777,19 @@ private void killMostExpensiveQuery() {
" Query %s got killed because using %d bytes of memory on
%s, exceeding the quota",
maxUsageTuple._queryId, maxUsageTuple.getAllocatedBytes(),
_instanceType)));
interruptRunnerThread(maxUsageTuple.getAnchorThread());
+ LOGGER.error("Heap used bytes {} exceeds critical level {}",
_usedBytes, _criticalLevel);
Review Comment:
This is a very good point. I have refactored the logging to reflect
_criticalLevel exceed and _criticalLevelAfterGC exceed differently. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
