somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1123277948
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ########## @@ -0,0 +1,332 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator; + +import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; +import javax.annotation.Nullable; +import org.apache.calcite.rel.RelFieldCollation; +import org.apache.commons.collections.CollectionUtils; +import org.apache.pinot.common.datablock.DataBlock; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.core.data.table.Key; +import org.apache.pinot.query.planner.logical.RexExpression; +import org.apache.pinot.query.routing.VirtualServerAddress; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; +import org.apache.pinot.query.runtime.blocks.TransferableBlockUtils; +import org.apache.pinot.query.runtime.operator.utils.AggregationUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * The WindowAggregateOperator is used to compute window function aggregations over a set of optional + * PARTITION BY keys, ORDER BY keys and a FRAME clause. The output data will include the projected + * columns and in addition will add the aggregation columns to the output data. + * [input columns, aggregate result1, ... aggregate resultN] + * + * The window functions supported today are SUM/COUNT/MIN/MAX/AVG/BOOL_OR/BOOL_AND aggregations. Window functions also + * include other types of functions such as rank and value functions. + * + * Unlike the AggregateOperator which will output one row per group, the WindowAggregateOperator + * will output as many rows as input rows. + * + * Note: This class performs aggregation over the double value of input. + * If the input is single value, the output type will be input type. Otherwise, the output type will be double. + * + * TODO: + * 1. Add support for OVER() clause with ORDER BY only or PARTITION BY ORDER BY + * 2. Add support for rank window functions + * 3. Add support for value window functions + * 4. Add support for custom frames + * 5. Add support for null direction handling (even for PARTITION BY only queries with custom null direction) + */ +public class WindowAggregateOperator extends MultiStageOperator { + private static final String EXPLAIN_NAME = "WINDOW"; + private static final Logger LOGGER = LoggerFactory.getLogger(WindowAggregateOperator.class); + + private final MultiStageOperator _inputOperator; + private final List<RexExpression> _groupSet; + private final OrderSetInfo _orderSetInfo; + private final WindowFrame _windowFrame; + private final List<RexExpression.FunctionCall> _aggCalls; + private final List<RexExpression> _constants; + private final DataSchema _resultSchema; + private final AggregationUtils.Accumulator[] _windowAccumulators; + private final Map<Key, List<Object[]>> _partitionRows; + + private TransferableBlock _upstreamErrorBlock; + + private int _numRows; + private boolean _readyToConstruct; + private boolean _hasReturnedWindowAggregateBlock; + + public WindowAggregateOperator(MultiStageOperator inputOperator, List<RexExpression> groupSet, + List<RexExpression> orderSet, List<RelFieldCollation.Direction> orderSetDirection, + List<RelFieldCollation.NullDirection> orderSetNullDirection, List<RexExpression> aggCalls, int lowerBound, + int upperBound, boolean isRows, List<RexExpression> constants, DataSchema resultSchema, DataSchema inputSchema, + long requestId, int stageId, VirtualServerAddress virtualServerAddress) { Review Comment: yeah sure let me explore this as a future improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
