walterddr commented on code in PR #10358: URL: https://github.com/apache/pinot/pull/10358#discussion_r1122018628
########## pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/RowBlock.java: ########## @@ -16,18 +16,29 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.pinot.core.common; +package org.apache.pinot.core.operator.blocks; + +import java.util.List; +import org.apache.pinot.common.utils.DataSchema; + /** - * - * Not used for now, since most of the predicates make use of inverted index. - * Revisit when we push predicate evaluation up into the operator + * The {@code RowBlock} contains a block of rows. Review Comment: ```suggestion * The {@code RowBlock} contains a block of rows and a {@link DataSchema}. * each row contains a collection of entries that conforms with the DataSchema. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org