walterddr commented on code in PR #10358:
URL: https://github.com/apache/pinot/pull/10358#discussion_r1122004936
##########
pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java:
##########
@@ -29,4 +41,41 @@ public interface BlockDocIdSet {
* ascending order.
*/
BlockDocIdIterator iterator();
+
+ /**
+ * Returns the number of entries (SV value contains one entry, MV value
contains multiple entries) scanned in the
+ * filtering phase. This method should be called after the filtering is done.
+ */
+ long getNumEntriesScannedInFilter();
+
+ /**
+ * For scan-based FilterBlockDocIdSet, pre-scans the documents and returns a
non-scan-based FilterBlockDocIdSet.
+ */
+ default BlockDocIdSet toNonScanDocIdSet() {
Review Comment:
`toPreScannedDocIdSet`
##########
pinot-core/src/main/java/org/apache/pinot/core/common/Block.java:
##########
@@ -19,41 +19,7 @@
package org.apache.pinot.core.common;
/**
- *
- * A block represents a set of rows.A segment will contain one or more blocks
- * Currently, it assumes only one column per block. We might change this in
- * future
+ * A {@code Block} represents the data block returned by the {@link Operator}.
Each operator can return multiple blocks.
Review Comment:
```suggestion
* A {@code Block} represents the data block returned by the {@link
Operator}. Each operator can return multiple blocks.
* A {@code Block} can contain one or more columns of data depending on the
operator implementation.
```
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/valsets/TransformBlockValSet.java:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.core.operator.docvalsets;
+package org.apache.pinot.core.operator.valsets;
Review Comment:
what's the motivation of this change, seems to me docitset and docvalueset
gives me clearer understanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
