gortiz commented on code in PR #10191: URL: https://github.com/apache/pinot/pull/10191#discussion_r1121447418
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexConfig.java: ########## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import org.apache.pinot.spi.config.BaseJsonConfig; + + +/** + * This is the base class used to configure indexes. + * + * The common logic between all indexes is that they can be enabled or disabled. + * + * Indexes that do not require extra configuration can directly use this class. + */ +public class IndexConfig extends BaseJsonConfig { + public static final IndexConfig ENABLED = new IndexConfig(true); + public static final IndexConfig DISABLED = new IndexConfig(false); + private final boolean _enabled; Review Comment: I don't get why that should be reflected in the name of the attribute. How is it configured in JSON is unrelated to the name of the attribute. In following PRs we will decide what to do with this, but what I initially did was to make it optional, so when an index is specified you usually do not write the `enable`/`disable` attribute unless you actually want to disable it. I prefer to use `enable` to avoid too many negations and reduce the reading complexity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
