[GitHub] [pinot] ankitsultana commented on a diff in pull request #10285: [multistage] Store Sender/Receiver Stage Id in MailboxId

[via GitHub]

ankitsultana commented on code in PR #10285:
URL: https://github.com/apache/pinot/pull/10285#discussion_r1107525180


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxIdentifier.java:
##########
@@ -50,4 +50,8 @@ public interface MailboxIdentifier {
    * @return true if sender and receiver are in the same JVM.
    */
   boolean isLocal();
+
+  int getSenderStageId();
+
+  int getReceiverStageId();

Review Comment:
   Done



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -153,10 +155,10 @@ protected TransferableBlock getNextBlock() {
   }
 
   private static JsonMailboxIdentifier toMailboxId(
-      VirtualServer destination, long jobId, int stageId, VirtualServerAddress 
sender) {
+      VirtualServer destination, long jobId, int stageId, int receiverStageId, 
VirtualServerAddress sender) {

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org