ankitsultana commented on code in PR #10285:
URL: https://github.com/apache/pinot/pull/10285#discussion_r1107522502
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/JsonMailboxIdentifier.java:
##########
@@ -106,6 +116,16 @@ public boolean isLocal() {
return _fromAddress.equals(_toAddress);
}
+ @Override
Review Comment:
Edit: JsonIgnore is not needed for these fields since it's okay to allow the
getters to be used for serde by jackson. The ignoreUnknown properties at the
class level takes care of the behavior I was looking for. See this class' UT
for more.
https://fasterxml.github.io/jackson-annotations/javadoc/2.5/com/fasterxml/jackson/annotation/JsonIgnore.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
